fix(results): keep raw transcripts valid jsonl - #1632
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
e9e22fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c48d9a9.agentv.pages.dev |
| Branch Preview URL: | https://provider-transcript-parity.agentv.pages.dev |
christso
force-pushed
the
provider-transcript-parity
branch
from
July 4, 2026 04:45
e5e8370 to
e9e22fe
Compare
christso
marked this pull request as ready for review
July 4, 2026 04:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provider runs that emitted human-readable stream logs were writing those bytes directly to
transcript-raw.jsonl, so consumers expecting JSONL could fail on Codex CLI and app-server bundles. Raw provider logs now remain parseable: existing JSONL logs are preserved unchanged, and non-JSONL logs are wrapped as line records that keep the original text available for inspection.This keeps the result index contract honest for transcript sidecars while preserving stdout/stderr and target-execution evidence in the existing sidecars.
Validation
origin/mainafter fix(eval): accept target id in targets files #1631 (6f2110b9); current branch heade9e22fec.bun run buildbun test apps/cli/test/commands/eval/artifact-writer.test.tsexamples/features/readme-quickstart/evals/my-eval.eval.yaml --target local-openai, score 100%, bundle.agentv/results/2026-07-04T03-53-57-344Z/tmp/agentv-av-7yhs/provider-sanity.eval.yaml --target codex-cli-local, score 100%, bundle.agentv/results/2026-07-04T04-01-07-928Z; verifiedtranscript-raw.jsonlparses as JSONLexamples/showcase/trace-evaluation/fixtures/imported-codex-transcript.jsonl, score 100%, bundle.agentv/results/2026-07-04T04-01-46-126Z; verified Read/Grep/Edit ordering and transcript summary countscodex app-server --stdio; it still fails at the protocol boundary withFailed to deserialize JSONRPCMessage, but the failure bundle now emits valid raw JSONL at.agentv/results/2026-07-04T04-01-40-791ZFollow-up Provider Checks
Using local endpoint
http://127.0.0.1:10531/v1, dummy key, modelgpt-5.4-mini, and ignoredid-based targets under.agentv/cache/av-7yhs/:pi-cli-local-openai: PASS, score/pass rate 100%, bundle.agentv/results/2026-07-04T04-42-29-558Z.transcript-raw.jsonlvalid JSONL (1092 lines); normalized transcript preserves user then assistant order; index links transcript, raw transcript, metrics, grading, stdout, stderr, and target-execution sidecars.copilot-cli-local-openai: PASS, score/pass rate 100%, bundle.agentv/results/2026-07-04T04-43-11-965Z.transcript-raw.jsonlvalid JSONL (9 lines); normalized transcript preserves user then assistant order; index links transcript, raw transcript, metrics, grading, stdout, stderr, and target-execution sidecars.pi-sdk-local-openai: blocked/error, bundle.agentv/results/2026-07-04T04-42-48-115Z. Child runner exits before provider metadata withpi-sdk child runner exit: exit code 1; direct import check confirms@earendil-works/pi-coding-agentis not installed/resolvable.transcript-raw.jsonlis valid JSONL (2 lines), preserving user then error assistant order.copilot-sdk-local-openai: blocked/error, bundle.agentv/results/2026-07-04T04-43-00-087Z. Child runner exits before provider metadata withcopilot-sdk child runner exit: exit code 1; direct import check confirms@github/copilot-sdkis not installed/resolvable.transcript-raw.jsonlis valid JSONL (2 lines), preserving user then error assistant order.Codex CLI was not rerun after the rebase because #1631 changed target
idvalidation/generation, not Codex CLI provider behavior or the raw transcript fix; the current follow-uptargets.yamlvalidates withid, and existing post-fix Codex CLI evidence remains applicable.Blockers Not Fixed Here
@openai/codex-sdk.@earendil-works/pi-coding-agentis not installed/resolvable.@github/copilot-sdkis not installed/resolvable.Related
Related: av-7yhs